stubbing out all the pages in the nav #20
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eggheadio/egghead-io-nextjs/lmgudxs84 |
| export async function loadLessons() { | ||
| const query = /* GraphQL */ ` | ||
| query getLessons { | ||
| lessons(per_page: 25) { |
There was a problem hiding this comment.
This is a placeholder. I'd like to explore the pagination with that new Next.js hook you found.
There was a problem hiding this comment.
We actively killed the /lessons route in favor of filtered search as a paginated list of 5000+ videos is...
https://twitter.com/chrisbiscardi/status/1172527924945096706?s=20
They capture it in this thread well.
| ) | ||
| } | ||
|
|
||
| export default function Courses({lessons}) { |
There was a problem hiding this comment.
| export default function Courses({lessons}) { | |
| export default function Lessons({lessons}) { |
There was a problem hiding this comment.
On egghead.io as it is now we dropped /lessons in favor of /search with a filter, and I think this is a good move. 5000+ lessons in a paginated list aren't very structurally predisposed to learning. 😂
| ) | ||
| } | ||
|
|
||
| export default function Courses({allCourses}) { |
There was a problem hiding this comment.
/courses also forwards to /search on egghead.io for similar reasons as /lessons. The paginated list isn't very useful in practice.
I can see an argument for a curated /courses page with on-page filtered search.
| export async function loadLessons() { | ||
| const query = /* GraphQL */ ` | ||
| query getLessons { | ||
| lessons(per_page: 25) { |
There was a problem hiding this comment.
We actively killed the /lessons route in favor of filtered search as a paginated list of 5000+ videos is...
https://twitter.com/chrisbiscardi/status/1172527924945096706?s=20
They capture it in this thread well.
This is mainly to fix 404s in the nav.
I also played around with /lessons and /courses. I copy/pasted a tailwind card layout from here and filled them in with data from graphql. I imagine these will be deleted or refactored, but it was cool to see how far you could get with a tailwind component and graphql data.
I spent some time with types in courses and lessons, but back out those changes because that will be a bigger discussion.