Merge pull request #4 from skillrecordings/ng/fix-typos #16
Annotations
11 warnings
Lint and Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, pnpm/action-setup@v2.2.4, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Lint and Test:
packages/player/src/components/controls/closed-captions-menu-button-control.tsx#L60
React Hook React.useCallback has missing dependencies: 'activateSubtitlesTrack' and 'clearSubtitlesTracks'. Either include them or remove the dependency array
|
Lint and Test:
packages/player/src/components/cue-form.tsx#L27
React Hook React.useEffect has a missing dependency: 'videoService'. Either include it or remove the dependency array. Mutable values like 'formRef.current' aren't valid dependencies because mutating them doesn't re-render the component
|
Lint and Test:
packages/player/src/components/cue-form.tsx#L59
Using `<img>` could result in slower LCP and higher bandwidth. Consider using `<Image />` from `next/image` to automatically optimize images. This may incur additional usage or cost from your provider. See: https://nextjs.org/docs/messages/no-img-element
|
Lint and Test:
packages/player/src/components/menu/menu-button.tsx#L16
React Hook React.useEffect has a missing dependency: 'activateMenuItem'. Either include it or remove the dependency array
|
Lint and Test:
packages/player/src/components/shortcut.tsx#L112
React Hook React.useEffect has missing dependencies: 'rootElem' and 'videoService'. Either include them or remove the dependency array
|
Lint and Test:
packages/player/src/components/shortcut.tsx#L376
React Hook React.useCallback has missing dependencies: 'canAddNotes' and 'cueFormElem?.input'. Either include them or remove the dependency array
|
Lint and Test:
packages/player/src/components/shortcut.tsx#L444
React Hook React.useCallback has missing dependencies: 'rootElem' and 'shortcutsEnabled'. Either include them or remove the dependency array
|
Lint and Test:
packages/player/src/components/shortcut.tsx#L479
React Hook React.useCallback has missing dependencies: 'rootElem' and 'videoService'. Either include them or remove the dependency array
|
Lint and Test:
packages/player/src/components/video.tsx#L70
React Hook React.useEffect has a missing dependency: 'videoService'. Either include it or remove the dependency array. Mutable values like 'videoElemRef.current' aren't valid dependencies because mutating them doesn't re-render the component
|
Lint and Test:
packages/player/src/hooks/use-subtitles-track-list.ts#L34
React Hook React.useEffect has missing dependencies: 'activateSubtitlesTrack' and 'language'. Either include them or remove the dependency array
|