-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log consumed capacity if set #4
Conversation
Pull Request Test Coverage Report for Build 4680022371Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@@ -22,6 +27,7 @@ def __init__(self, table_name, | |||
aws_access_key_id=None, | |||
aws_secret_access_key=None, | |||
aws_session_token=None): | |||
self.table_name_postfix = table_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.table
contains prefixes of env and also "test-"
f85cfb5
to
cd089aa
Compare
It seems good 👍 |
cd089aa
to
51171b4
Compare
pydjamodb/connection.py
Outdated
table_settings = logging_settings.get(self.table_name_postfix, {}) | ||
return table_settings.get('RETURN_CONSUMED_CAPACITY'), table_settings.get('COLUMNS', set()) | ||
|
||
def _log_consumed_capacity(self, data, operation_name, updated_columns): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this method used? Maybe I'm missing something but didn't you want to use this method on lines 163-171?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is leftover. I have deleted it. Thanks
51171b4
to
94fde18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the logged extra_data looks like this:
settings then looks like (configurable for each table):