Using the ngTable has slowed things down tremendously

[sebgoa]

we need to figure out what the issue is, if its inherent to ngTable we need to revert and find an alternative.
Right now the load time is terrible

[raynjamin]

@Runseb TL;DR: The problem is not ngTable, you need to cache your service call results if you want faster rendering times. Alternatively, add a loading gif to the page to indicate the items are being refreshed.

I'm testing using the first tab, pods, but I believe that this same logic applies to other scenarios in which ngTable is being used.

The issue I'm seeing is definitely not inherent to ngTable, but rather the service that is giving ngTable data. In the refreshPods method, I replaced the service call to an array literal and the table came right up consistently.

I also noticed that the refreshPods method was getting called four times every time the page loaded. This was my initial suspicion as to the culprit of why the table was taking too long to load, but upon further investigation, once the first call to refreshPods() changes the podsReady variable to true, the view doesn't care about subsequent calls to refreshPods(). Nevertheless, it was concerning, so I figured out why.

The controller was being instantiated twice due to duplicated controller entries in the routes table as well as corresponding view partials. I removed all references to controllers from the routes file. Now we're down to 2 calls to refreshPods().

The second call is coming from the ws listener. For some reason, on page load, the websocket listener you have established is firing with data and resulting in another call to refreshPods().

Again, these aren't preventing the table from loading each time, but are patterns that will give you headaches.

[sebgoa]

Thanks a ton for checking this @raynjamin
The web socket connection is used to listen for changes in the underlying data.
If there is a change, the web socket will receive an event.

Ideally we could update all pods with the data received on the ws, but for now we are triggering a new refershPod().

Note that the refreshPod() should only be triggered if the ws receives something. it should not be triggered on every page load.

[raynjamin]

So you have an option here.. currently refreshPods() is getting the latest data whenever the controller is instantiated, which is whenever the route calls for it.

I'm thinking the best bet would to change the controller to cache the list, and refreshWhatever() will asynchronously grab the latest data and update the list, while maybe having a progress indicator. Good?

[sebgoa]

sounds good, but updating the cached data based on what the ws sends might be a bit tricky/take time.

[raynjamin]

I'll take a look. We might have to rethink how we uniquely identify the
entries in the table
On Fri, Nov 6, 2015 at 9:30 AM runseb notifications@github.com wrote:

sounds good, but updating the cached data based on what the ws sends might
be a bit tricky/take time.

—
Reply to this email directly or view it on GitHub
#3 (comment).