Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the feature to use a fixed subdomain and get the domain as dynamic parameter.
Implementation was easy: We added the dot as separator before parameters.
With another modification, We are not fully sure, if there are side effects. All tests passes.
Now we only add a slash add beginning of $url, when the route start with a parameter.
I don't think there are side effects, because the prefix slash is only need to match on routes, which start with a parameter. Otherwise there are existing separators in url.
But it is not fully clear, why a separator is needed, because regular expressions also match without one.
We would adjust the solution, depending on feedback.
To check all options, we need a "debugOutputNoReset" function in TestRouter, we also commit.