Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic domain, fixed Subdomain #594

Merged

Conversation

swarnat
Copy link
Contributor

@swarnat swarnat commented Oct 3, 2021

We need the feature to use a fixed subdomain and get the domain as dynamic parameter.
Implementation was easy: We added the dot as separator before parameters.

With another modification, We are not fully sure, if there are side effects. All tests passes.
Now we only add a slash add beginning of $url, when the route start with a parameter.

I don't think there are side effects, because the prefix slash is only need to match on routes, which start with a parameter. Otherwise there are existing separators in url.
But it is not fully clear, why a separator is needed, because regular expressions also match without one.

We would adjust the solution, depending on feedback.

To check all options, we need a "debugOutputNoReset" function in TestRouter, we also commit.

@swarnat swarnat changed the title Dymanic domain, fixed Subdomain Dynamic domain, fixed Subdomain Oct 8, 2021
@DeveloperMarius
Copy link
Contributor

Hello,

nice implementation, but can you provide an example where you need a dynamic second level domain?

~ Marius

@skipperbent skipperbent changed the base branch from master to v4-development February 9, 2023 01:27
@skipperbent skipperbent merged commit e38a406 into skipperbent:v4-development Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants