Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile needs small update #26

Closed
maxgvz opened this issue Jan 2, 2023 · 1 comment
Closed

Makefile needs small update #26

maxgvz opened this issue Jan 2, 2023 · 1 comment

Comments

@maxgvz
Copy link

maxgvz commented Jan 2, 2023 •
edited
Loading

On the FreeBSD with locale UTF-8, I've encountered with 'tr' utility problem. In fact I could made it work only with using LANG=C patch. Like this:

bios-micro8088.bin: bios.bin
	dd if=/dev/zero ibs=1k count=40 | LANG=C tr "\000" "\377" > bios-micro8088.bin
	cat bios.bin >> bios-micro8088.bin
	dd if=/dev/zero ibs=1k count=64 | LANG=C tr "\000" "\377" >> bios-micro8088.bin
...

Would be helpful to apply this patch to all commands with 'tr'. This patch works okay on linux OS as well.
skiselev added a commit that referenced this issue Jan 6, 2023
@skiselev
Fix for issue #26 - set LANG=C for tr
f4c98b7 
Signed-off-by: Sergey Kiselev <skiselev@gmail.com>
@skiselev
Copy link
Owner

skiselev commented Jan 6, 2023

Fixed in master branch. Thank you for your contribution!

@skiselev skiselev closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skiselev @maxgvz