Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generated from SDCC wasn't running correctly when JP NC was being used as the C flag wasn't being set on subtractions; example:
The c code for this was simply:
And was immediately failing! I guess due to the way sub is used vs cp and nc is used vs nz this only presents itself with code generated from SDCC;
#1 Looking at the details at z80.info for subtraction:
The carry flag should be set if the result of the subtraction is less than 0; So it appears the C flag is just being incorrectly set;
#2 Looking at another emulator written in C; the following code is used:
The logic is different; but ultimately results in C being set for my example; backing up the fact that there's an issue in this version;
Thanks,
Chris