Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a different regular expression to escape ansi colors. #9

Merged
merged 3 commits into from
Mar 3, 2015

Conversation

brandoncazander
Copy link
Contributor

My regex-fu isn't very good, so I shamelessly stole the new regular expression from http://superuser.com/a/380778

Tested against python 2.6.9 (not working before) and 2.7.8 (working before).

Fixes #8.

@coveralls
Copy link

Coverage Status

Coverage increased (+37.09%) to 49.01% when pulling efed148 on brandoncazander:master into 5e652d0 on skoczen:master.

@skoczen
Copy link
Owner

skoczen commented Feb 17, 2015

Awesome, thanks for this fix! I'll have cycles to review and get this out hopefully soon, (not tonight, sadly), but didn't want to leave you hanging.

Thanks for making polytester better!

Oh, can you please put your name and desired attribution in AUTHORS, as well?

Thanks,
-Steven

@coveralls
Copy link

Coverage Status

Coverage increased (+37.09%) to 49.01% when pulling 9198168 on brandoncazander:master into 5e652d0 on skoczen:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+37.09%) to 49.01% when pulling 9198168 on brandoncazander:master into 5e652d0 on skoczen:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+37.09%) to 49.01% when pulling 9198168 on brandoncazander:master into 5e652d0 on skoczen:master.

@brandoncazander
Copy link
Contributor Author

Thanks @skoczen!

@skoczen
Copy link
Owner

skoczen commented Mar 3, 2015

Merging this in now, release shortly!

@skoczen skoczen merged commit 9198168 into skoczen:master Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip_ansi_colors() fails on various python versions
3 participants