Configflow #274
Merged
Configflow #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` custom_components.skodaconnect.config_flow::SkodaConnectConfigFlow calls async_show_progress without passing a progress task, this is not valid and will break in Home Assistant Core 2024.8. Please report it to the custom integration author ``` Fixes skodaconnect#268
|
Lgtm, also, let's add black to the pre-commit config. |
Farfar
approved these changes
May 16, 2024
|
Looking good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commits are black formatting only and bumping the HA version. Actual fix is in the last commit so you probably want to focus on that while reviewing.
Fixes the following warning:
Reference: https://developers.home-assistant.io/docs/data_entry_flow_index/
Tested configuration flow on HA Core 2024.4.3. No more warning and can pass configuration.
Fixes #268