Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#scheme suffix in URL breaks SkoHub Vocabs #295

Closed
TobiasNx opened this issue Apr 9, 2024 · 1 comment · Fixed by #296
Closed

#scheme suffix in URL breaks SkoHub Vocabs #295

TobiasNx opened this issue Apr 9, 2024 · 1 comment · Fixed by #296
Assignees
@acka47 @sroertgen

Comments

@TobiasNx
Copy link

TobiasNx commented Apr 9, 2024

See:
https://skohub.io/hbz/lobid-vocabs/heads/master/purl.org/lobid/libtype.html#scheme
sroertgen added a commit that referenced this issue Apr 9, 2024
@sroertgen
Add concept scheme to embedded concepts #295
254ba85 
The concept scheme was not yet added to the embedded concepts for hash uris.
If visiting a hash uri concept scheme directly this resulted in a crash.
@sroertgen sroertgen linked a pull request Apr 9, 2024 that will close this issue
Add concept scheme to embedded concepts #295 #296
Merged
@sroertgen
Copy link
Contributor

Assigned @acka47 to review #296

sroertgen added a commit that referenced this issue Apr 23, 2024
@sroertgen
Align display of hash uri and slash uri concepts #295
fa91c4a 
Moves the CSS out of the component and thereby aligns the display of concepts, conept schemes and collections.
sroertgen added a commit that referenced this issue Apr 24, 2024
@sroertgen
Merge pull request #296 from skohub-io/295-scheme-suffix
cf08bc9 
Add concept scheme to embedded concepts #295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acka47 acka47

@sroertgen sroertgen

Labels
None yet
Projects
SkoHub
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add concept scheme to embedded concepts #295 skohub-io/skohub-vocabs
3 participants
@acka47 @sroertgen @TobiasNx