Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ some generic mime types item.rb #46

Closed
wants to merge 2 commits into from
Closed

+ some generic mime types item.rb #46

wants to merge 2 commits into from

Conversation

127
Copy link
Contributor

@127 127 commented Mar 17, 2014

+mime-types:
eot, mp3, mp4

127 added 2 commits March 17, 2014 17:28
+mime-types: 
eot, mp3, mp4
@skoji
Copy link
Owner

skoji commented Mar 18, 2014

Thanks for PR. But there are some problems in commit ba7d7fe .

  1. Item#guess_mimetypes do not return value.
    It just loops over @@mime_types and just 'puts' the matched result.
    Should be return instead of puts.
  2. end missing, so whole library will not work.

Besides, I am not sure to add method Item#add_mime_type. I think there is no need to add special mimetype to guess_mimetypes. You can specify any mimetype explicitly with add_item.

I'll merge this PR by cherry-picking the commit a109973 .

@skoji skoji closed this Mar 18, 2014
@127
Copy link
Contributor Author

127 commented Mar 18, 2014

Sorry about ba7d7fe it's an error — pushed wrong sample.
I'm trying to take away the whole mime types stuff to a single standalone class now for my own purpose. Will pull request it later as a proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants