Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT - Removes Python 3.8 support #418

Merged
merged 6 commits into from
May 3, 2024

Conversation

lazarust
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@lazarust lazarust changed the title Removes Python 3.8 support MNT - Removes Python 3.8 support Apr 28, 2024
dependabot bot and others added 3 commits April 30, 2024 20:05
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.12 to 1.8.14.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.8.12...v1.8.14)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lazarust lazarust force-pushed the remove-python-3.8-support branch from 7f1b29d to a096856 Compare May 1, 2024 01:05
@lazarust lazarust requested a review from adrinjalali May 1, 2024 01:06
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as why the diff looks so large, but other than the nit looks good to me.

setup.py Show resolved Hide resolved
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@lazarust
Copy link
Contributor Author

lazarust commented May 2, 2024

@adrinjalali The diff is so large because I fixed the indention on the steps part. For some reason, the indention was off so when I edited the file VScode automatically fixed it

@adrinjalali adrinjalali merged commit 384b462 into skops-dev:main May 3, 2024
15 of 16 checks passed
@lazarust lazarust deleted the remove-python-3.8-support branch May 3, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants