Fix column indexes. Fixes #4 and partly #16 (create function checks need to be fixed as well) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnssnmrcs
changed the title
|
Maybe a separate issue should be created for updating the create-function to not check null versionstamps for non-unique keys |
jnssnmrcs
commented
Jul 1, 2023
|
I'm fixing the create function in a separate branch at the moment but waiting for this to get merged before I put up a PR for it |
|
I realized it was something else that made the tests fail, it's fixed now and they pass. |
|
Thank you for making the changes! And apologies for taking so long with merging, have been incredibly busy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates correct index kv keys depending on the type of index. Currently the create function is failing for non-unique indexes because it currently checks all keys for null versionstamps, which should not be done for non-unique index keys. This change also requires exactly 1 or 0 index types per column, since it does not make sense to have more than one of the currently supported index types on a single property.