Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect notThrows → toThrowError conversion #14

Merged
merged 1 commit into from
Dec 1, 2016
Merged

Fix incorrect notThrows → toThrowError conversion #14

merged 1 commit into from
Dec 1, 2016

Conversation

sapegin
Copy link
Contributor

@sapegin sapegin commented Dec 1, 2016 

- t.notThrows(() => new Function(result), SyntaxError);  // eslint-disable-line no-new-func
+ expect(() => new Function(result)).toThrowError(SyntaxError);  // eslint-disable-line no-new-func

Should be not.toThrowError.

@skovhus
Copy link
Owner

skovhus commented Dec 1, 2016

Thanks @sapegin for fixing this. This looks good to me.

@skovhus skovhus merged commit 8352460 into skovhus:master Dec 1, 2016
@sapegin sapegin deleted the fix-throws branch December 1, 2016 10:53
@skovhus
Copy link
Owner

skovhus commented Dec 1, 2016

Released as 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapegin @skovhus