feat: export main as tsm #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealparmesh
force-pushed
the
export-main-function
branch
from
dde46ab
to
8924cb8
Compare
therealparmesh
force-pushed
the
export-main-function
branch
from
8924cb8
to
d9f85b8
Compare
|
@skovy Please let me know if exposing this function is something you'd like. |
therealparmesh
force-pushed
the
export-main-function
branch
2 times, most recently
from
653c560
to
1f30ba4
Compare
|
@therealparmesh yes, this makes sense to me. I intended for it to be used programmatically but didn't want to export it until someone had a use case for it 👍 |
therealparmesh
force-pushed
the
export-main-function
branch
2 times, most recently
from
ee6a564
to
0346aa7
Compare
|
@skovy Awesome! This PR should be good to go (pending CI). |
|
@therealparmesh looks great! can you remove the |
therealparmesh
force-pushed
the
export-main-function
branch
from
0346aa7
to
5e3f1a6
Compare
|
@skovy Good catch! Done. |
skovy
approved these changes
Apr 27, 2022
|
🎉 This PR is included in version 6.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be really useful to be able to programmatically invoke
tsmas opposed to running it via a CLI command.People can currently do this in a hacky way by importing the
mainfunction fromtyped-scss-modules/dist/lib/main.js.This PR adds a real entry point and adds the exporting of type declarations.
Example usage:
import tsm from 'typed-scss-modules';