Migrate from createClass() to es6 classes #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I've been wanting to update the demo, or use react-storybook instead. I'd also like to make sure builds work with webpack (since that's what most people, including me, are using nowadays). I'll pull this in and push a new build. |
|
I also don't like the "Note on data synchronization" that I merged in at one point. I'd like to update that for people b/c it doesn't look like any other typical React usage I've seen.... |
|
Happy to! |
|
@sman591 - I just published 2.4.0 with your changes. Thanks again! |
sman591
pushed a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
Apr 20, 2017
Migrate from createClass() to es6 classes # Conflicts: # lib/index.js
Merged
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
May 2, 2017
Restores functionality introduced in skratchdot#22 but broken by skratchdot#71
sman591
added a commit
to sman591/react-bootstrap-multiselect
that referenced
this pull request
May 3, 2017
Restores functionality introduced in skratchdot#22 but broken by skratchdot#71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
Also had to add babel to the gulp build in order to properly build the demo app.
The demo app & readme also could use some updating, but I figure that can happen outside of this PR.
I've tested this with the demo app & my own app (though had to fix a bootstrap import on a custom branch).