Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dist build #72

Merged
merged 2 commits into from
Apr 21, 2017
Merged

Fix dist build #72

merged 2 commits into from
Apr 21, 2017

Conversation

sman591
Copy link
Contributor

@sman591 sman591 commented Apr 20, 2017

My last commit in #71 introduced a "dist" build, which was mistaken for a working build. The React class wasn't being properly exported due to how Browserify processed the source.

  • Instead of passing the dist build through both browserify and babel, just use babel
  • Fix React error related to setting the ref

@skratchdot
Copy link
Owner

Thanks!

@skratchdot skratchdot merged commit 71bb964 into skratchdot:master Apr 21, 2017
@skratchdot
Copy link
Owner

I just published this as 2.4.1

@sman591 sman591 deleted the fix-dist branch April 21, 2017 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sman591 @skratchdot