Shutdown revamp #68
Merged
Shutdown revamp #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
force-pushed
the
shutdown-revamp
branch
4 times, most recently
from
07c2b8c
to
dd8ab53
Compare
agis
force-pushed
the
shutdown-revamp
branch
from
46c3f8f
to
fa27ed6
Compare
| // non-blocking manner | ||
| func (s *Server) shutdown() { | ||
| // stop accepting new consumers | ||
| s.managerCancel() |
There was a problem hiding this comment.
I think this should be a blocking call. What about something like s.manager.StopAcceptingConsumers() to push this behavior to the ConsumerManager?
agis
force-pushed
the
shutdown-revamp
branch
2 times, most recently
from
e9e5663
to
2b414af
Compare
| // shutdown closes current clients and also stops accepting new clients in a | ||
| // non-blocking manner | ||
| func (s *Server) shutdown() { | ||
| s.manager.StopAcceptingConsumers() |
There was a problem hiding this comment.
This is still racy (not trully blocking). As implemented the mutex protects the teardown variable, the map is not protected, so we still can end up with a new consumer when the map iteration takes place.
agis
force-pushed
the
shutdown-revamp
branch
2 times, most recently
from
bc5789c
to
ea337b1
Compare
ctrochalakis
approved these changes
Sep 27, 2018
This patch aims to minimize the downtime for producers during server upgrades and generally make the shutdown process more robust. The flow is now the following: 1) shutdown signal is received 2) stop accepting new consumers and close clients with at least 1 consumer 3) stop accepting new producers and close rest of the clients 4) shutdown and restart This way, producer downtime is reduced to the time elapsed between (3) and (4), which should be less than a second. Nevertheless, clients should still have sane retry defaults configured anyway, because some downtime will still occur. This patch also changes the client IDs (Client.ID) to be unique per-client. These are internal and should not affect the consumer logic, since we introduce Client.consID and we use that for consumer IDs.
agis
force-pushed
the
shutdown-revamp
branch
from
424ac6a
to
5e402e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to minimize the downtime for producers and make the
shutdown process generally more robust. The flow is now the following:
This way, producer downtime is reduced to the time elapsed between (3)
and (5), which should be less than a second. Nevertheless, clients
should still have sane retry defaults configured anyway, because some
downtime will still occur.
Also added a hard timeout of 5 seconds around the shutdown process.