consumer: poll: ignore transient error #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdiba
force-pushed
the
ignore_transient_poll_err
branch
from
bbaf27f
to
b6b1fab
Compare
agis
suggested changes
Sep 19, 2018
consumer.go
Outdated
| // isErrorTerminal is a utility function checking if the returned errors should be treated as transient. | ||
| // It will probably get replaced with a librdKafka provided function, informing on each error's severity | ||
| // https://github.com/edenhill/librdkafka/issues/1987#issuecomment-422008750 | ||
| func isErrorTerminal(err rdkafka.Error) bool { |
There was a problem hiding this comment.
How about something simpler like IgnorableErr()? This way we keep a consistent wording (in commit, documentation & code).
The logic in the body will be easier to read too.
There was a problem hiding this comment.
Actually, I think the function is not needed. If we ever reuse the same piece of code in more spots, then we could convert it to a function. Just a comment above the relevant piece of code with the link to edenhill's answer should be sufficient.
consumer.go
Outdated
| default: | ||
| c.log.Printf("Unknown event type: %T", e) | ||
| } | ||
|
|
||
| return nil, nil | ||
| } | ||
|
|
||
| // isErrorTerminal is a utility function checking if the returned errors should be treated as transient. |
There was a problem hiding this comment.
You could reduce this to:
ignorableError returns true if err is an error that should be ignored. [...]
Treat `Poll GroupCoordinator response error: Local: Broker transport failure` errors as transient. For more info check out: confluentinc/librdkafka#1987 (comment)
0xdiba
force-pushed
the
ignore_transient_poll_err
branch
from
b6b1fab
to
9461ec7
Compare
agis
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat
Poll GroupCoordinator response error: Local: Broker transport failureerrors as transient.For more info check out: confluentinc/librdkafka#1987 (comment)