-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: bump to Python 3.10 #606
Conversation
To be merged after #605 is merged |
Uhm I might not have the rights :) but I wanted to rename "dump" to "bump" in the title of the PR :) |
Did I get things wrong: I see that the tests still run Python 3.9 and 3.8? Is it because the build matrix of a PR is changed only with the yml is changed in the main branch? |
I don't think so, but maybe 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on it, but you want to remove "3.8" and "3.9" in L34 from test.yml
python-version: ["3.8", "3.9", "3.10"]
I can't comment on it, but you want to remove "3.8" and "3.9" in L34 from test.yml
Good eye!!
|
Amazing! Merging :) |
This reverts commit 0cd2c12.
There's an issue with the CI strategy matrix, it should be: include:
- os: "ubuntu-latest"
os-name: "Ubuntu"
- os: "macos-latest"
os-name: "MacOS"
- dependencies-version: "dev"
- dependencies-version: "dev, min-py310"
python-version: "3.10"
dependencies-version-type: "minimal" I created a revert by mistake; I'm creating another PR to fix it. |
Currently, we only want as users people who are early adopters and quite agile.
I'm in favor of dropping support for Python versions earlier than 3.10. If nothing else, it will make our build matrix lighter.