Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: bump to Python 3.10 #606

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Conversation

GaelVaroquaux
Copy link
Member

Currently, we only want as users people who are early adopters and quite agile.

I'm in favor of dropping support for Python versions earlier than 3.10. If nothing else, it will make our build matrix lighter.

@GaelVaroquaux GaelVaroquaux marked this pull request as ready for review June 15, 2023 09:59
@GaelVaroquaux
Copy link
Member Author

To be merged after #605 is merged

@glemaitre
Copy link
Member

Uhm I might not have the rights :) but I wanted to rename "dump" to "bump" in the title of the PR :)

@GaelVaroquaux GaelVaroquaux changed the title MAINT: dump to Python 3.10 MAINT: bump to Python 3.10 Jun 15, 2023
@GaelVaroquaux
Copy link
Member Author

Did I get things wrong: I see that the tests still run Python 3.9 and 3.8?

Is it because the build matrix of a PR is changed only with the yml is changed in the main branch?

@LilianBoulard
Copy link
Member

Is it because the build matrix of a PR is changed only with the yml is changed in the main branch?

I don't think so, but maybe 🤔
Your changes seem alright though, so I'd up for merging, fix later if necessary

Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on it, but you want to remove "3.8" and "3.9" in L34 from test.yml

python-version: ["3.8", "3.9", "3.10"]

@GaelVaroquaux
Copy link
Member Author

GaelVaroquaux commented Jun 15, 2023 via email

@LilianBoulard
Copy link
Member

Amazing! Merging :)

@LilianBoulard LilianBoulard merged commit 0cd2c12 into skrub-data:main Jun 15, 2023
17 of 18 checks passed
Vincent-Maladiere added a commit that referenced this pull request Jun 15, 2023
@Vincent-Maladiere
Copy link
Member

There's an issue with the CI strategy matrix, it should be:

            include:
              - os: "ubuntu-latest"
                os-name: "Ubuntu"
              - os: "macos-latest"
                os-name: "MacOS"
              - dependencies-version: "dev"
              - dependencies-version: "dev, min-py310"
                python-version: "3.10"
                dependencies-version-type: "minimal"   

I created a revert by mistake; I'm creating another PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants