Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern type hinting #609

Merged
merged 3 commits into from
Jun 16, 2023
Merged

Use modern type hinting #609

merged 3 commits into from
Jun 16, 2023

Conversation

LilianBoulard
Copy link
Member

Following #606, we can now use PEP 585 type hints, which should simplify the code quite a bit.

@LilianBoulard LilianBoulard added the enhancement New feature or request label Jun 15, 2023
@LilianBoulard LilianBoulard self-assigned this Jun 15, 2023
GaelVaroquaux
GaelVaroquaux approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@GaelVaroquaux GaelVaroquaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have no love for reviewing such PRs that do many small changes on plenty of pages.

@GaelVaroquaux
Copy link
Member

There are conflicts to be resolved

Vincent-Maladiere
Vincent-Maladiere approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving conflicts. Thanks for keeping up with the PEP standards; this improves readability.

@LilianBoulard LilianBoulard merged commit dc77f61 into skrub-data:main Jun 16, 2023
22 checks passed
@LilianBoulard LilianBoulard deleted the update_type_hints branch June 16, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaelVaroquaux GaelVaroquaux GaelVaroquaux approved these changes

@Vincent-Maladiere Vincent-Maladiere Vincent-Maladiere approved these changes

Assignees

@LilianBoulard LilianBoulard

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LilianBoulard @GaelVaroquaux @Vincent-Maladiere