Use modern type hinting - #609
Merged
Merged
Conversation
GaelVaroquaux
approved these changes
Jun 15, 2023
GaelVaroquaux
left a comment
GaelVaroquaux
left a comment
Member
There was a problem hiding this comment.
LGTM.
I have no love for reviewing such PRs that do many small changes on plenty of pages.
Member
|
There are conflicts to be resolved |
Vincent-Maladiere
approved these changes
Jun 16, 2023
Vincent-Maladiere
left a comment
Vincent-Maladiere
left a comment
Member
There was a problem hiding this comment.
LGTM after resolving conflicts. Thanks for keeping up with the PEP standards; this improves readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #606, we can now use PEP 585 type hints, which should simplify the code quite a bit.