Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "packaging" as a requirement #712

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Add "packaging" as a requirement #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2689004
add packaging in reqs
Vincent-Maladiere Aug 21, 2023
03b5f4b
clarify warning message
Vincent-Maladiere Aug 21, 2023
f167ecb
actually, remove the warning entirely
Vincent-Maladiere Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ install_requires =
numpy>=1.23.5
scipy>=1.9.3
pandas>=1.5.3
packaging>=23.1
python_requires = >=3.10

[options.extras_require]
Expand Down
14 changes: 3 additions & 11 deletions skrub/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,7 @@
"""
from pathlib import Path as _Path

try:
from ._check_dependencies import check_dependencies

check_dependencies()
except ModuleNotFoundError:
import warnings

warnings.warn(
"packaging is not available, dependencies versions will not be checked."
)

from ._check_dependencies import check_dependencies
from ._datetime_encoder import DatetimeEncoder
from ._deduplicate import compute_ngram_distance, deduplicate
from ._fuzzy_join import fuzzy_join
Expand All @@ -24,6 +14,8 @@
from ._table_vectorizer import SuperVectorizer, TableVectorizer
from ._target_encoder import TargetEncoder

check_dependencies()

with open(_Path(__file__).parent / "VERSION.txt") as _fh:
__version__ = _fh.read().strip()

Expand Down
Loading