Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "packaging" as a requirement #712

Merged

Conversation

Vincent-Maladiere
Copy link
Member

@Vincent-Maladiere Vincent-Maladiere commented Aug 21, 2023

What does this PR implement?
A solution to #698, which fixes the regression introduced in #648

What changes?

  • Add 'packaging' to the requirements in setup.cfg
  • Slightly change the warning message to make it more explicit remove the warning message

@Vincent-Maladiere Vincent-Maladiere changed the title Add "packaging" as a requirements Add "packaging" as a requirement Aug 21, 2023
Copy link
Member

@jovan-stojanovic jovan-stojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just see if @LilianBoulard agrees

@Vincent-Maladiere Vincent-Maladiere merged commit 89f2a78 into skrub-data:main Aug 25, 2023
25 checks passed
@Vincent-Maladiere Vincent-Maladiere deleted the add_packaging_in_reqs branch August 25, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants