Rescue all error classes in TracePoint block #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change proposed in this PR might or might not be a good idea, so feel free to reject it. I think that the main risk/downside is that, by rescuing all error classes (and also not even logging that an error occurred), we might swallow errors that we actually want/need to know about. But it does fix the current test failures on |
|
Thanks for diving in, @davidrunger! I'll try to check this over the weekend 🙏 |
|
Closing in favor of #4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1
Also fixes the error mentioned here (currently occurring on
main): #2 (comment)