Skip to content

Commit

Permalink
[MNT] fix wheels test for release (#124)
Browse files Browse the repository at this point in the history
Code for getting wheel name for windows wheel test is incorrect, fixed.

Also deactivate fail-tast flag for better diagnostics.
  • Loading branch information
fkiraly committed Oct 10, 2023
1 parent 587be54 commit 98547bb
Showing 1 changed file with 35 additions and 3 deletions.
38 changes: 35 additions & 3 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@ jobs:
name: wheels
path: wheelhouse/*

test_wheels:
test_unix_wheels:
needs: build_wheels
name: Test wheels on ${{ matrix.os }} with ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false # to not fail all combinations if just one fail
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
os: [ubuntu-latest, macOS-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
Expand All @@ -57,10 +58,41 @@ jobs:
run: |
python -m pytest
test_windows_wheels:
needs: build_wheels
name: Test wheels on ${{ matrix.os }} with ${{ matrix.python-version }}
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false # to not fail all combinations if just one fail
matrix:
os: [windows-latest]
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- uses: actions/download-artifact@v3
with:
name: wheels
path: wheelhouse

- name: Get wheel filename
run: echo "WHEELNAME=$(ls ./wheelhouse/skpro-*none-any.whl)" >> $env:GITHUB_ENV

- name: Install wheel and extras
run: python -m pip install "${{ env.WHEELNAME }}[all_extras,dev]"

- name: Run tests
run: |
python -m pytest
upload_wheels:
name: Upload wheels to PyPI
runs-on: ubuntu-latest
needs: [build_wheels,test_wheels]
needs: [build_wheels,test_unix_wheels,test_windows_wheels]

steps:
- uses: actions/download-artifact@v3
Expand Down

0 comments on commit 98547bb

Please sign in to comment.