Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Logistic distribution #240

Closed
wants to merge 1 commit into from
Closed

Conversation

malikrafsan
Copy link
Contributor

@malikrafsan malikrafsan commented Apr 6, 2024

Reference Issues/PRs

#22

What does this implement/fix? Explain your changes.

Logistic probability distribution

Does your contribution introduce a new dependency? If yes, which one?

no

What should a reviewer concentrate their feedback on?

  • Energy formula for logistic distribution

Did you add any tests for the change?

  • Yes, I try to install this library locally using pip install --editable .[dev,test] and create simple driver program to use this new distribution

Any other comments?

  • I use the formula from Wikipedia, which can be accessed here
  • For log_pdf, I use wolfram alpha to derive the formula, here is the screenshot
    Screenshot from 2024-04-07 01-05-52

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

@fkiraly fkiraly added enhancement module:probability&simulation probability distributions and simulators labels Apr 6, 2024
@fkiraly
Copy link
Collaborator

fkiraly commented Apr 6, 2024

For log_pdf, I use wolfram alpha to derive the formula

Interesting - I would just have used the standard logarithm rules to cancel exps etc.

Do you have an opinion on which representation is more stable, numerically?

Intuitively, at least, I would think cancelling as many exps as possible is better.

@malikrafsan malikrafsan closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:probability&simulation probability distributions and simulators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants