Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Docs are not being built during CI check #4097

Closed
achieveordie opened this issue Jan 11, 2023 · 5 comments
Closed

[BUG] Docs are not being built during CI check #4097

achieveordie opened this issue Jan 11, 2023 · 5 comments
Labels
bug Something isn't working documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution

Comments

@achieveordie
Copy link
Collaborator

Describe the bug

I believe that all of the current PRs only show "Expected — Waiting for status to be reported" for docs/readthedocs.org:sktime check. I don't know what is causing this but it must be recent since I remember this check passing few days ago.

To Reproduce

Expected behavior

Additional context

See #4093, #4075, #4087 etc.

Versions

@achieveordie achieveordie added the bug Something isn't working label Jan 11, 2023
@fkiraly fkiraly added documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution labels Jan 11, 2023
@fkiraly
Copy link
Collaborator

fkiraly commented Jan 11, 2023

Hm, this seems to be a GitHub GUI issue?

Because if you check directly on readthedocs, it looks like it gets built:
https://readthedocs.org/projects/sktime/builds/

@achieveordie
Copy link
Collaborator Author

I agree. The builts are there when we see through the provided link but GH doesn't show it. I doubt this is a sktime issue if that is the case.

@miraep8
Copy link
Collaborator

miraep8 commented Jan 12, 2023

Yes, have also been looking into this as its blocking a PR from one of the new contributors I am working with. Curiously, if you look at checks that have run from the PR itself you see 18 (this number includes the ReadTheDocs build). But if you actually click on the detailed test summary the ReadTheDocs build disappears from the count and isn't included in the overall test run graph.
image

Now, perhaps this isn't surprising because the read the docs test (from what I can tell) isn't actually included in the test.yml file where we put together all the other tests (and I assume is just linked in from some other Github actions widget or add on? I am not totally sure how it works right now). One potential solution that we could try out could be to explicitly use the Github action for Read The Docs? Just wondering if something might be up with how its currently running and it might be nice to have it run through the same interface as everything else?

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 12, 2023

I've temporarily removed the requirement for the readthedocs check to pass, so merges become possible again (if everything else runs).
I think it's the reporting that's failing, readthedocs still builds, see above.

@fkiraly
Copy link
Collaborator

fkiraly commented Feb 23, 2023

Hm, readthedocs integration of CI checks is back, just shortly after recovery of the readthedocs sktime project.
See #4237

One conjecture could be that the hijack of the sktime project happened already around January 11, and that somehow upset the integration, or it got intentionally removed.

Now that readthedocs account and the sktime readthedocs project is under control again, it seems whatever blocked the integration has been resolved, too.

@fkiraly fkiraly closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

3 participants