-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] section on new tests in PULL_REQUEST_TEMPLATE
#4093
Conversation
Hi, @achieveordie I have successfully set up the dev environment with the help of the guide. I have made these commits from my local machine and created a new PR. Please check and guide me. Thank you! |
The first check has passed which means the dev environment was set up properly. I'd recommend you not change the template when you're making a PR (instead leave the irrelevant parts blank and add new parts as you see fit) since it doesn't link this PR to the original issue and we'll have to manually close that issue once this PR merges. Content-wise, everything looks good to me. Although I think we can now remove the third point inside "For all contributors" which asks "I've added unit tests and made sure they pass locally" since that is being moved to its own subsection. |
@achieveordie Will follow the PR template from here on. Thanks for the section! By the way, I have removed the third point under the 'For all contributors section'. Kindly check. Thank you! |
PULL_REQUEST_TEMPLATE
Adds a separate section in the PR template to ask contributors whether they have added any new tests. Fixes sktime#4066
Description
Added a separate section to ask contributors whether they have added any new tests.
Issue
#4066