New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Constructor of any DL estimator to pass non-default values to underlying Network
object
#4075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable and like a good fix, but is still a draft - is this ready to be merged?
I've added a test to ensure it doesn't fail in the future. Should be ready to be merged now. |
seems to have crashed while downloading |
failed again with timeout while downloading |
I guess something was down temporarily, I saw the failures on other checks as well. I wonder why docs are not being built, any idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward fix for a hard-to-detect and quite consequential bug.
Seems like all params are now passed on. We can deal with the general design problem later.
…nderlying `Network` object (sktime#4075) Fixes sktime#4067: - [x] Manually correct behaviour for all current estimators by passing all values from estimator object to network object during estimator initialization. - [x] Add a test to ensure this works properly.
Reference Issues/PRs
Fixes #4067
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
We need to discuss if there is another way that is superior to the current solution.
Any other comments?
PR checklist
For all contributions
For new estimators