Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] readthedocs build failing with AttributeError("'TocTree' object has no attribute 'get_toctree_ancestors'") #5117

Closed
fkiraly opened this issue Aug 17, 2023 · 3 comments · Fixed by #5119
Closed

[BUG] readthedocs build failing with AttributeError("'TocTree' object has no attribute 'get_toctree_ancestors'") #5117

fkiraly opened this issue Aug 17, 2023 · 3 comments · Fixed by #5119
Labels
bug Something isn't working documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 17, 2023

Readthedocs builds are erroring out with sphinx.errors.ThemeError: An error happened in rendering the page about. Reason: AttributeError("'TocTree' object has no attribute 'get_toctree_ancestors'"), since yesterday, I think?

I can identify no immediate reason why they would.

This seems high priority as it prevents us from updating documentation.
@fkiraly fkiraly added bug Something isn't working documentation Documentation & tutorials labels Aug 17, 2023
@fkiraly fkiraly mentioned this issue Aug 17, 2023
Merged
@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 17, 2023

Might be due to the sphinx 7.2.0 release 12 hours ago, so attempted fix adds an upper bound: #5118

@fkiraly fkiraly mentioned this issue Aug 17, 2023
Merged
3 tasks
fkiraly added a commit that referenced this issue Aug 17, 2023
@fkiraly
[MNT] restrict sphinx < 7.2.0 to address documentation build failure (
f12a787 
#5118)

Temporary fix for #5117, which is likely caused by the 7.2.0 release 12
hours ago.
@fkiraly
Copy link
Collaborator Author

fkiraly commented Aug 17, 2023

Update: that fixes it, though we should still understand what we need to do to make our doc build compatible with 7.2.0 and above.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Aug 17, 2023
@yarnabrina
Copy link
Collaborator

This is definitely caused by the new Sphinx release: sphinx-doc/sphinx#11608

There's a new release as well, going to try in a new MNT PR.

@yarnabrina yarnabrina mentioned this issue Aug 17, 2023
Merged
fkiraly pushed a commit that referenced this issue Aug 17, 2023
@yarnabrina
[MNT] update sphinx upper bound after skipping 7.2.0 (#5119)
72b191c 
Closes #5117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MNT] update sphinx upper bound after skipping 7.2.0 yarnabrina/sktime-fork
2 participants
@fkiraly @yarnabrina