Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] speed up test_probabilistic_metrics by explicit fixture generation instead of using forecaster fit/predict #5115

Merged
merged 4 commits into from Aug 18, 2023

Conversation

Ram0nB
Copy link
Contributor

@Ram0nB Ram0nB commented Aug 17, 2023

Reference Issues/PRs

#2890

What does this implement/fix? Explain your changes.

Explicit prediction generation rather than via the NaiveForecaster/NaiveVariance to speed up testing

Does your contribution introduce a new dependency? If yes, which one?

No

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the sktime root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.
    See here for further details on the algorithm maintainer role.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, much obliged! Looks like this shaved off a minute from the tests! We are approaching the 10min event horizon :-)

The docs failure appears unrelated to me, see here: #5117

Intending to merge this after 0.22.0 release which is imminent, i.e., in a couple days, until then others can also have a look.

@fkiraly fkiraly changed the title [MNT] Explicit prediction generation [MNT] speed up test_probabilistic_metrics by explicit fixture generation instead of using forecaster fit/predict Aug 18, 2023
@fkiraly fkiraly merged commit 326b4b2 into sktime:main Aug 18, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants