Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] transformer base class to allow multivariate output if input is always univariate #1706

Merged
merged 5 commits into from
Dec 7, 2021
Merged

[ENH] transformer base class to allow multivariate output if input is always univariate #1706

merged 5 commits into from
Dec 7, 2021

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Dec 6, 2021

Fixes #1697 by introducing the following base class behaviour: returning pd.DataFrame output if transform output is multivariate but input was pd.Series.

@fkiraly fkiraly requested a review from mloning as a code owner December 6, 2021 00:57
@fkiraly fkiraly added the module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing label Dec 6, 2021
mloning
mloning previously approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but changes look fine.

sktime/transformations/base.py Outdated Show resolved Hide resolved
@fkiraly
Update sktime/transformations/base.py
e1d8aef 
Co-authored-by: Markus Löning <markus.loning@gmail.com>
@fkiraly
Copy link
Collaborator Author

fkiraly commented Dec 7, 2021

appveyor timing out, but otherwise ok.
Side note: suggested code change by @mloning had a typo/bug. Fixed that but "morally" accepted the code change (i.e., the correct version of it).

@fkiraly fkiraly merged commit 450c481 into main Dec 7, 2021
@fkiraly fkiraly deleted the fix-multivariate-trafo-output branch December 7, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloning mloning mloning left review comments

Assignees
No one assigned
Labels
module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] transformer multi-column pd.DataFrame output conversion fails
2 participants
@fkiraly @mloning