-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Bump numpy version to >=1.21.0, <1.22 #1921
Conversation
Looks like nothing broke after bumping numpy 🙂 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Quick Q, why does nothing break? Because we discontinued support for python 3.6
(which in turn influences the upper pandas
bound)?
This is not an easy question to answer, but recent changes in #1620 made it easy to introduce this change also dropping 3.6 released some of the constraints on package versions. |
So, here's another question, @lmmentel: why a lower bound of 01.21.0? This does not include the old version, and may break things for users. |
I bumped it since I got a dependabot alert about my other package that there are vulnerabilities in numpy the recommended action is to bump it at least to 1.21, I can decrease the lower bound if you are afraid of users not being able to use sktime. BTW this will only affect people installing sktime 0.10.0 onward so I don't think it's an issue. |
This violates the "Thou shalt have no other packages before sktime" clause in the sktime code of conduct ... or am I confusing this with another literature source? :-) |
Is there any specific reason not to include numpy version 1.22 ? |
@ilkersigirci, since this is a general Q, answering it here: #2037 |
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Bumping numpy to >=1.21.0,<1.22
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
For new estimators