Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Bump numpy version to >=1.21.0, <1.22 #1921

Merged
merged 5 commits into from
Jan 24, 2022
Merged

[MNT] Bump numpy version to >=1.21.0, <1.22 #1921

merged 5 commits into from
Jan 24, 2022

Conversation

lmmentel
Copy link
Contributor

@lmmentel lmmentel commented Jan 23, 2022

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Bumping numpy to >=1.21.0,<1.22

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@lmmentel
Copy link
Contributor Author

lmmentel commented Jan 23, 2022

Looks like nothing broke after bumping numpy 🙂 🚀

TonyBagnall
TonyBagnall previously approved these changes Jan 23, 2022
fkiraly
fkiraly previously approved these changes Jan 24, 2022
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Quick Q, why does nothing break? Because we discontinued support for python 3.6 (which in turn influences the upper pandas bound)?

@lmmentel
Copy link
Contributor Author

lmmentel commented Jan 24, 2022

Quick Q, why does nothing break? Because we discontinued support for python 3.6 (which in turn influences the upper pandas bound)?

This is not an easy question to answer, but recent changes in #1620 made it easy to introduce this change also dropping 3.6 released some of the constraints on package versions.

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 24, 2022

So, here's another question, @lmmentel: why a lower bound of 01.21.0? This does not include the old version, and may break things for users.
Would it be problematic to have this at 1.19.3 (the old version)?

@lmmentel
Copy link
Contributor Author

I bumped it since I got a dependabot alert about my other package that there are vulnerabilities in numpy the recommended action is to bump it at least to 1.21, I can decrease the lower bound if you are afraid of users not being able to use sktime. BTW this will only affect people installing sktime 0.10.0 onward so I don't think it's an issue.

@fkiraly fkiraly dismissed stale reviews from TonyBagnall and themself via ed92232 January 24, 2022 18:03
@fkiraly
Copy link
Collaborator

fkiraly commented Jan 24, 2022

I bumped it since I got a dependabot alert about my other package

This violates the "Thou shalt have no other packages before sktime" clause in the sktime code of conduct ... or am I confusing this with another literature source? :-)

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jan 24, 2022
@fkiraly fkiraly changed the title Bump numpy version [MNT] Bump numpy version to >= 1.21 Jan 24, 2022
@fkiraly fkiraly changed the title [MNT] Bump numpy version to >= 1.21 [MNT] Bump numpy version to >=1.21.0, <1.22 Jan 24, 2022
@fkiraly fkiraly merged commit 0c30cf3 into main Jan 24, 2022
@fkiraly fkiraly deleted the mnt/bump-numpy branch January 24, 2022 19:25
@ilkersigirci
Copy link

Is there any specific reason not to include numpy version 1.22 ?

@fkiraly
Copy link
Collaborator

fkiraly commented Feb 9, 2022

@ilkersigirci, since this is a general Q, answering it here: #2037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Upgrading to numpy 1.20 StatsModels and Numpy to have a >= version instead of == version
4 participants