[BUG] remove alpha arg from _boxcox, remove private method dependencies, ensure scipy 1.8.0 compatibility
#2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:transformations
This was referenced Apr 14, 2022
fkiraly
changed the title
alpha arg from _boxcox, remove _boxcox_conf_interval dependency, scipy 1.8.0 compatibilityalpha arg from _boxcox, remove private method dependencies, ensure scipy 1.8.0 compatibility
|
This PR fixes #1994, what I think is the last issue that prevents sktime from being compatible with The fix consists of the following:
|
|
tests don't run yet - why is everything stuck, @lmmentel? |
|
There was an incident with GHA recently which might've created a queue? 🤷 |
srggrs
added a commit
to Gridsight/sktime
that referenced
this pull request
Apr 19, 2022
* upstream/main: [ENH] more forecaster scenarios for testing: using `X` (sktime#2462) less uncertainty samples (sktime#2497) [ENH] remove error message on exogeneous X from DirRec reducer (sktime#2463) [BUG] fix accidental overwrite of default method/arg sequences in test scenarios (sktime#2457) changed references to fit-in-transform to fit_is_empty (sktime#2494) [MNT] loosen strict upper bound on `scipy` to 1.9.0 (sktime#2474) [DOC] Added clustering module to API docs (sktime#2429) [ENH] Add prediction intervals for `UnobservedComponets` forecaster (sktime#2454) [BUG] remove `alpha` arg from `_boxcox`, remove private method dependencies, ensure scipy 1.8.0 compatibility (sktime#2468) [BUG] removed metric integration notebook (sktime#2476) [ENH] refactor `_predict_moving_cutoff` and bugfix, outer `update_predict_single` should be called (sktime#2466) [ENH, BUG] Distance refactor and bug fix (sktime#2268) [ENH] add new argument return_tags to all_estimators (sktime#2410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1994, what I think is the last issue that prevents sktime from being compatible with
scipy1.8.0.The fix is to remove the otherwise unused
alphaarg from_boxcox, which allows to remove the_boxcox_conf_interval dependencyentirely