Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fixed bug with distance factory 1d arrays #2691

Merged
merged 2 commits into from
May 25, 2022
Merged

Conversation

chrisholder
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR fixes a bug where the distance factory was incorrectly handling a 1d array being passed.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
  • The PR title starts with either [ENH], [DOC] or [BUG] indicating whether the PR topic is related to enhancement, documentation or bug
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a PR summary. What whas the bug? What is being fixed?

@TonyBagnall
Copy link
Contributor

the bug is that distance functions generated by the distance factory were not handling 1D arrays correctly by reshaping them to 2d, and this fixes it

@TonyBagnall TonyBagnall merged commit df68376 into main May 25, 2022
@TonyBagnall TonyBagnall deleted the distance-1d-array branch May 25, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants