[ENH] increase stateless scope of FunctionTransformer and TabularToSeriesAdaptor
#3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:transformations
fkiraly
added a commit
that referenced
this pull request
Aug 23, 2022
Addresses #2179 This PR deprecates the row transformers, i.e., `SeriesToSeriesRowTransformers` and `SeriesToPanelRowTransformers`. The original reason to have these was to allow application of series transformers to panel data. This is functionality which is now integrated into the base class, i.e., `fit` and `transform` automatically vectorize (see #2219). For the deprecation period, `make_row_transformer` will return the transformer passed to it (since it already has the functionality it was meant to attach), and the row transformers will simply patch through all transformer methods. Relies on #3087 to ensure panel compatibility of `sklearn` `FunctionTransformer`, by closing the gap between "stateless" scopes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a number of improvements around
FunctionTransformerandTabularToSeriesAdaptor, resulting in increased scope of the case wherefitis being skipped ("stateless" insklearnterminology):FunctionTransformerhas checks fromfitmoved intotransform, in order to ensure an emptyfitand allow vectorization with different number of instances infitandtransformfor panel dataTabularToSeriesAdaptornow checks if thetransformerpassed hassklearntags, and ifstateless, skipsfitand sets the tag accordinglyTabularToSeriesAdaptormore robust totransformreturns that are not 2Dnp.ndarrayby coercion