[ENH] get_fitted_params for nested sklearn components
#3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
enhancement
fkiraly
changed the title
get_fitted_params for sklearn componentsget_fitted_params for nested sklearn components
fkiraly
added a commit
that referenced
this pull request
Nov 3, 2022
…test parameters (#3632) This PR further isolates `statsmodels` by replacing some `statsmodels` dependent estimators in test parameter settings by `sktime` native ones. Relies on: * #3639 which serves as a mock to isolate `statsmodels` from test cases that require parameter estimators. * #3645 which is used to isolate `statsmodels` in the `FittedParamExtractor`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility of the
get_fitted_paramsinterface point forsklearncomponents.So far, this did not work, since
sklearncomponents did not inherit fromBaseObjectand did not have theget_fitted_paramsinterface.This is solved by applying the method externally instead of relying it to be attached to the object if it inherits from the
sklearnBaseEstimator.