Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skbase refactor - part 2: all_estimators lookup #3777

Merged
merged 86 commits into from Apr 28, 2023
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Nov 13, 2022

Part 2 of the change action to move the base module to skbase.

Moves BaseObject and core base functionality to the skbase package.

Part 2, relies on:

Migrated:

  • all_estimators - uses skbase.all_objects under the hood now.
  • from part 1 - BaseObject. The sktime BaseObject is a child of skbase BaseObject with some added features that are currently sktime specific.

todo, will happen in different parts of this:

  • TestAllObjects
  • add tests

@fkiraly fkiraly changed the title Experimental - DO NOT MERGE: BaseObject refactor - part 2: all_estimators lookup Experimental - DO NOT MERGE: skbase refactor - part 2: all_estimators lookup Mar 4, 2023
@fkiraly fkiraly changed the title Experimental - DO NOT MERGE: skbase refactor - part 2: all_estimators lookup skbase refactor - part 2: all_estimators lookup Apr 27, 2023
@fkiraly fkiraly marked this pull request as ready for review April 27, 2023 18:15
@fkiraly fkiraly merged commit 624e18d into main Apr 28, 2023
22 checks passed
@fkiraly fkiraly deleted the baseobject-refactor-part2 branch April 28, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution refactor Restructuring without changing its external behavior. Neither fixing a bug nor adding a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant