Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add test for all_estimators tag filter #4512

Merged
merged 2 commits into from Apr 28, 2023
Merged

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Apr 27, 2023

This adds a test for the tag filter parameter of all_estimators, i.e., that only the filtered estimators are returned, and the filtered estimators are returned.

@fkiraly fkiraly added the module:base-framework BaseObject, registry, base framework label Apr 27, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Apr 28, 2023

adds safety to release action skbase, merging early

@fkiraly fkiraly merged commit 85a0168 into main Apr 28, 2023
22 checks passed
@fkiraly fkiraly deleted the test-lookup-tag_filter branch April 28, 2023 17:56
fkiraly added a commit that referenced this pull request Apr 28, 2023
Part 2 of the change action to move the base module to `skbase`.

Moves `BaseObject` and core `base` functionality to the `skbase`
package.

Part 2, relies on:

* part 1: #3151
* #4512

Migrated:
* `all_estimators` - uses `skbase.all_objects` under the hood now.
* from part 1 - `BaseObject`. The `sktime` `BaseObject` is a child of
`skbase` `BaseObject` with some added features that are currently
`sktime` specific.

todo, will happen in different parts of this:
* `TestAllObjects`
* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:base-framework BaseObject, registry, base framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant