[ENH] sklearn 1.2.0 compatibility - remove private _check_weights import in KNeighborsTimeSeriesClassifier and -Regressor
#3918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
maintenance
fkiraly
changed the title
_check_weights import in KNeighborsTimeSeriesClassifier_check_weights import in KNeighborsTimeSeriesClassifier and -Regressor
fkiraly
changed the title
_check_weights import in KNeighborsTimeSeriesClassifier and -Regressorsklearn 1.2.0 compatibility - remove private _check_weights import in KNeighborsTimeSeriesClassifier and -Regressor
fkiraly
added a commit
that referenced
this pull request
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a compatibility issue with
sklearn 1.2and removes the private import_check_weightsfromKNeighborsTimeSeriesClassifierandKNeighborsTimeSeriesRegressor.This can be done without deprecation or change in functionality, because
_check_weightswas just an erroneous leftover from an earlier version that used inheritance and not composition.Right now, the
sklearnclassifier is wrapped as a component, so_check_weights(or its 1.2 equivalent) is called again inside the component - therefore, naive removal simply removes an unnecessary duplication.