[MNT] sklearn 1.2.0 compatibility - remove normalize=False args from RidgeClassifierCV
#3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
the
maintenance
patrickzib
previously approved these changes
Dec 11, 2022
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thank you, looks good. I cannot approve, as I do not have write access to sktime, yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes superfluous
normalize=Falseargs fromRidgeClassifierCV.The arg has been deprecated in
sklearn 1.2.0, but was defaultnormalize=Falseprior.Simply removing the arg makes the occurrences compatible with
sklearn 1.2.0.Further, this PR removes use of the
normalizeargument from one of the secondary notebooks.