[DOC] changing import path for plot_cluster_algorithm
#3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi devs, thanks for this library! I was trying to use the example in the **Time Series Clustering** paragraph, but `plot_cluster_algorithm` was in `sktime.clustering.evaluation._plot_clustering` but in `sktime.clustering.utils.plotting._plot_partitions`. I hope this change might be useful for others too.
miraep8
approved these changes
Dec 16, 2022
lmmentel
approved these changes
Dec 17, 2022
fkiraly
added a commit
that referenced
this pull request
Dec 28, 2022
…t_dependencies` (#3955) This extends `_check_soft_dependencies` to also accept single arguments that are tuples or lists of strings. That is, formerly, it was valid to call `_check_soft_dependencies("package1", "package2")` but not `_check_soft_dependencies(("package1", "package2"))` `_check_soft_dependencies(["package1", "package2"])` Now all the above are valid and mean the same. This prevents developer or user error (due to unintuitive/ambiguous signature) as was fixed in #3945
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi devs,
thanks for this library!
I was trying to use the example in the Time Series Clustering paragraph of the Getting Started page, but
plot_cluster_algorithmwas not insktime.clustering.evaluation._plot_clusteringbut insktime.clustering.utils.plotting._plot_partitions.Therefore, this PR changes this line.
I hope this might be useful for others too.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Changing the import of
plot_cluster_algorithmfromsktime.clustering.evaluation._plot_clusteringtosktime.clustering.utils.plotting._plot_partitions.Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
For new estimators