[MNT] Bump isort to 5.12.0 in pre-commit config #4167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for helping out with this, @snnbotchway! I thought I already tried updating But I see you did it differently, so let's try what this does. |
|
A new release(5.12.0) was just released an hour ago. |
snnbotchway
changed the title
|
Ah! Well spotted! |
|
Thanks a lot for reviewing @fkiraly |
|
yes, that's true! |
|
Sure, done! |
fkiraly
approved these changes
Jan 28, 2023
|
Thanks for fixing, @snnbotchway! This has caused me quite a headache today! |
|
Don't mention it!
Thanks for taking the time to review my PR
…On Sat, 28 Jan 2023, 9:45 pm Franz Király, ***@***.***> wrote:
Thanks for fixing, @snnbotchway <https://github.com/snnbotchway>! This
has caused me quite a headache today!
—
Reply to this email directly, view it on GitHub
<#4167 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO4A7D6EAIW3NL2T4VNVGXTWUWHRLANCNFSM6AAAAAAUJZJAKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
always! |
|
Sure
…On Sat, 28 Jan 2023, 10:00 pm Franz Király, ***@***.***> wrote:
always!
If you'd like to continue contributing, free to pick up one of the good
first issues and/or join one of the community sessions. Much appreciated.
—
Reply to this email directly, view it on GitHub
<#4167 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO4A7D6T36TKMMLZGJ6J7JTWUWJHNANCNFSM6AAAAAAUJZJAKQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the sort version in pre-commit to stop pre-commit checks from failing.
Closes #4162