Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI fails in code_quality isort hook, environment creation, at preparing metadata via pyproject.toml #4162

Closed
fkiraly opened this issue Jan 28, 2023 · 0 comments · Fixed by #4167
Labels
bug Something isn't working maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Jan 28, 2023

Since a few minutes ago, sktime CI fails at the first step when trying to install the env, with this traceback below.

This seems to be coming from the code_quality job, in there the isort hook when the python environment is being created, probably when trying to parse a pyproject.toml.

As a temporary workaround, isort has been removed here: #4164
but it should be added back.

Below is the traceback:

      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
    
stderr:
      error: subprocess-exited-with-error
      
      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [14 lines of output]
          Traceback (most recent call last):
            File "/home/runner/.cache/pre-commit/repohskwxkw8/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
              main()
            File "/home/runner/.cache/pre-commit/repohskwxkw8/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/home/runner/.cache/pre-commit/repohskwxkw8/py_env-python3/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
            File "/tmp/pip-build-env-3kaotqva/overlay/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 40, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
            File "/tmp/pip-build-env-3kaotqva/overlay/lib/python3.10/site-packages/poetry/core/factory.py", line 57, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
          
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.
@fkiraly fkiraly added bug Something isn't working maintenance Continuous integration, unit testing & package distribution labels Jan 28, 2023
@fkiraly fkiraly changed the title [BUG] CI fails at preparing metadata via pyproject.toml [BUG] CI fails at preparing metadata via pyproject.toml Jan 28, 2023
@fkiraly fkiraly changed the title [BUG] CI fails at preparing metadata via pyproject.toml [BUG] CI fails in code_quality isort hook, environment creation, at preparing metadata via pyproject.toml Jan 28, 2023
fkiraly added a commit that referenced this issue Jan 28, 2023
Temporary workaround for #4162 to allow other development and release.

Removes the `isort` pre-commit step to which the problem can be isolated.
Flowtter added a commit to Flowtter/crispy that referenced this issue Jan 28, 2023
Isort is currently not working with pre commit
sktime/sktime#4162
Flowtter added a commit to Flowtter/crispy that referenced this issue Jan 28, 2023
Isort is currently not working with pre commit
sktime/sktime#4162
Flowtter added a commit to Flowtter/crispy that referenced this issue Jan 28, 2023
Isort is currently not working with pre commit
sktime/sktime#4162
fkiraly pushed a commit that referenced this issue Jan 28, 2023
Updates the version of `isort` in `pre-commit`, which fixes #4162
Flowtter added a commit to Flowtter/crispy that referenced this issue Jan 29, 2023
Isort is currently not working with pre commit
sktime/sktime#4162
Flowtter added a commit to Flowtter/crispy that referenced this issue Jan 29, 2023
Isort is currently not working with pre commit
sktime/sktime#4162
DmitryPogrebnoy added a commit to NIRMA-PATIENT-INTAKE/disease that referenced this issue Jan 30, 2023
Randl added a commit to Randl/diffrax that referenced this issue Jan 31, 2023
evgenyshulman pushed a commit to databand-ai/dbnd that referenced this issue Jan 31, 2023
Randl added a commit to Randl/diffrax that referenced this issue Feb 2, 2023
VeckoTheGecko added a commit to VeckoTheGecko/parcels that referenced this issue Mar 2, 2023
Bump isort version for compatability with pre-commit
sktime/sktime#4162
mhordynski pushed a commit to deepsense-ai/ds-template that referenced this issue Jul 8, 2024
Fixes CI isort by updating version, CI stopped working for our internal project.
See also: sktime/sktime#4162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant