Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] improvements to "invitation to contribute" paragraph in documentation #4395

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

abhisek7154
Copy link
Contributor

@abhisek7154 abhisek7154 commented Mar 26, 2023

I have changed few lines to make it more grammatically correct and more appealing . Hope it helps.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@abhisek7154 abhisek7154 changed the title I have changed few lines to make it more grammatically correct and more. Hope it helps I have changed few lines to make it more grammatically correct and more appealing . Hope it helps Mar 26, 2023
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's go your with your new lines 17 and 18?
Line 17 and 18 do sound more friendly, thanks!

Line 16 indeed sounded strange prior to this PR, but I feel we're not quite there yet. How about:
"sktime is an open, community-driven project, seeking to provide opportunities to all. Therefore, we invite and wamly welcome any kind of contribution (not just code)."

@fkiraly fkiraly changed the title I have changed few lines to make it more grammatically correct and more appealing . Hope it helps [DOC] improvements to "invitation to contribute" paragraph in documentation Mar 26, 2023
@fkiraly fkiraly added the documentation Documentation & tutorials label Mar 26, 2023
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor changes to phrasing along the lines of my suggestions - thank you for your contribution!

@fkiraly fkiraly merged commit 02ece9d into sktime:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation & tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants