Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix informative error message on y input type check in BaseTransformer #4525

Merged
merged 2 commits into from May 5, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Apr 29, 2023

This PR fixes an unreported bug where the y input type check in BaseTransformer would not return additional information on failure reasons for the check. The failure reasons were accidentally not appended to the failure string.

@fkiraly fkiraly added module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing bugfix Fixes a known bug or removes unintended behavior labels Apr 29, 2023
@fkiraly fkiraly merged commit 38dfd3a into main May 5, 2023
22 checks passed
@fkiraly fkiraly deleted the basetrafo-ycheck-fix branch May 5, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug or removes unintended behavior module:transformations transformations module: time series transformation, feature extraction, pre-/post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant