Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix informative error message on y input type check in BaseTransformer #4525

Merged
merged 2 commits into from May 5, 2023
Merged

[BUG] fix informative error message on y input type check in BaseTransformer #4525

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4ac129
Update base.py
fkiraly Apr 29, 2023
844ba18
Merge branch 'main' into basetrafo-ycheck-fix
fkiraly Apr 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion sktime/transformations/base.py
View file
Open in desktop
Expand Up @@ -980,10 +980,12 @@ def _scitype_A_higher_B(scitypeA, scitypeB):
elif X_scitype == "Hierarchical":
y_possible_scitypes = ["Panel", "Hierarchical"]

y_valid, _, y_metadata = check_is_scitype(
y_valid, msg, y_metadata = check_is_scitype(
y, scitype=y_possible_scitypes, return_metadata=[], var_name="y"
)
if not y_valid:
for mtype, err in msg.items():
msg_invalid_input += f" [{mtype}: {err}] "
raise TypeError("y " + msg_invalid_input)

y_scitype = y_metadata["scitype"]
Expand Down