Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] warnings config #4536

Merged
merged 20 commits into from Oct 12, 2023
Merged

[MNT] warnings config #4536

merged 20 commits into from Oct 12, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented May 2, 2023 •
edited

This adds a config "warnings" to estimators and objects which allows to turn warnings off.

It also replaces all calls from estimators to warn with an sktime version that is a conditional based on an object that is queried for a tag. If the tag is not present or the object does not have a tag system, the sktime warn behaves like warnings.warn.

(does not affect warnings deprecated in 0.24.0, or outside classes)

Documentation is in #5306

@fkiraly fkiraly added enhancement Adding new functionality module:base-framework BaseObject, registry, base framework labels May 2, 2023
@fkiraly fkiraly mentioned this pull request May 4, 2023
Merged
fkiraly added a commit that referenced this pull request May 11, 2023
@fkiraly
[ENH] remove warning for length 1 forecasting pipelines (#4546)
8ee8149 
This PR removes the warning at construction of length 1 forecasting
pipelines.

While helpful to the user if they explicitly construct the pipeline via
the constructor, it is also raised when constructing pipelines via the
dunder, or the `make_pipeline` utility, in which case it confuses the
user.

As there is no way currently to evoke different behaviour in these two
cases, we should remove it instead.

Side consideration: I have thought whether the config system and
#4536 could be used for this - but
for this, the config would have to be set before construction, which is
currently not possible, not even with #4536.
@fkiraly fkiraly merged commit b57aaf4 into main Oct 12, 2023
1 check passed
@fkiraly fkiraly deleted the warnings-config branch October 12, 2023 10:53
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/main' into split-ci
1d6725b 
* origin/main: (24 commits)
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  [DOC] update docstring of `temporal_train_test_split` (sktime#4170)
  [ENH] parallelization backend calls in utility module - part 3, backend parameter passing in base class broadcasting (sktime#5405)
  [MNT] warnings config (sktime#4536)
  ...
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/main' into split-ci
00c83eb 
* origin/main: (24 commits)
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  [DOC] update docstring of `temporal_train_test_split` (sktime#4170)
  [ENH] parallelization backend calls in utility module - part 3, backend parameter passing in base class broadcasting (sktime#5405)
  [MNT] warnings config (sktime#4536)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
enhancement Adding new functionality module:base-framework BaseObject, registry, base framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fkiraly