Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] remove legacy except in TestAllEstimators for predict_proba #5386

Merged
merged 5 commits into from
Oct 12, 2023
Merged

[ENH] remove legacy except in TestAllEstimators for predict_proba #5386

merged 5 commits into from
Oct 12, 2023

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Oct 8, 2023

This removes the legacy except in TestAllEstimators for predict_proba which dates back to the time where it still depended on tensorflow.

@fkiraly fkiraly added module:tests test framework functionality - only framework, excl specific tests enhancement Adding new functionality labels Oct 8, 2023
@fkiraly fkiraly merged commit ce64c33 into main Oct 12, 2023
24 checks passed
@fkiraly fkiraly deleted the remove-pp-exc branch October 12, 2023 18:12
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/main' into split-ci
1d6725b 
* origin/main: (24 commits)
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  [DOC] update docstring of `temporal_train_test_split` (sktime#4170)
  [ENH] parallelization backend calls in utility module - part 3, backend parameter passing in base class broadcasting (sktime#5405)
  [MNT] warnings config (sktime#4536)
  ...
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/main' into split-ci
00c83eb 
* origin/main: (24 commits)
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  [DOC] update docstring of `temporal_train_test_split` (sktime#4170)
  [ENH] parallelization backend calls in utility module - part 3, backend parameter passing in base class broadcasting (sktime#5405)
  [MNT] warnings config (sktime#4536)
  ...
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/split-ci' into test-change-in-fo…
76a8869 
…recasting

* origin/split-ci: (25 commits)
  Revert "removed test-full workflow"
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  [DOC] update docstring of `temporal_train_test_split` (sktime#4170)
  [ENH] parallelization backend calls in utility module - part 3, backend parameter passing in base class broadcasting (sktime#5405)
  ...
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/split-ci' into test-change-in-base
103c30d 
* origin/split-ci: (25 commits)
  Revert "removed test-full workflow"
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  [DOC] update docstring of `temporal_train_test_split` (sktime#4170)
  [ENH] parallelization backend calls in utility module - part 3, backend parameter passing in base class broadcasting (sktime#5405)
  ...
yarnabrina added a commit to yarnabrina/sktime-fork that referenced this pull request Oct 14, 2023
@yarnabrina
Merge remote-tracking branch 'origin/auto-format-pyproject' into vali…
f353053 
…date-extras-workflow

* origin/auto-format-pyproject: (27 commits)
  added new hook
  format using new hook
  added new hook
  [DOC] fixing docstring example for `FhPlexForecaster` (sktime#4931)
  Revert "[MNT] instant release action" (sktime#5421)
  [MNT] instant release action (sktime#5419)
  Release 0.24.0 (sktime#5403)
  🚀 python 3.12 🚀  (sktime#5345)
  Revert "[MNT] instant release action" (sktime#5415)
  [MNT] 0.24.0 deprecations and change actions (sktime#5404)
  [MNT] [Dependabot](deps-dev): Update holidays requirement from <0.34,>=0.29 to >=0.29,<0.35 (sktime#5342)
  [MNT] Migrate from `pykalman` to `pykalman-bardo` (sktime#5277)
  [MNT] [Dependabot](deps-dev): Update skpro requirement from <2.1.0,>=2.0.0 to >=2.0.0,<2.2.0 (sktime#5396)
  [MNT] [Dependabot](deps-dev): Update numba requirement from <0.58,>=0.53 to >=0.53,<0.59 (sktime#5319)
  [MNT] update numba requirement from <0.58,>=0.53 to >=0.53,<0.59"" (sktime#5299)
  [MNT] instant release action (sktime#5265)
  Release 0.23.1 - omitted changelog commit (sktime#5413)
  Release 0.23.1 (sktime#5402)
  [ENH] Refactor of `DateTimeFeatures` tests to `pytest` fixtures (sktime#5397)
  [ENH] remove legacy except in `TestAllEstimators` for `predict_proba` (sktime#5386)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achieveordie achieveordie Awaiting requested review from achieveordie achieveordie is a code owner

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

@yarnabrina yarnabrina Awaiting requested review from yarnabrina yarnabrina is a code owner

Assignees
No one assigned
Labels
enhancement Adding new functionality module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fkiraly