Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid seaborn warning #472

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Avoid seaborn warning #472

merged 1 commit into from
Nov 8, 2020

Conversation

davidbp
Copy link
Contributor

@davidbp davidbp commented Nov 6, 2020

The function as written produces the following warning (which will become an error)

/usr/local/lib/python3.7/site-packages/seaborn/_decorators.py:43: FutureWarning: Pass the following variables as keyword args: x, y. From version 0.12, the only valid positional argument will be `data`, and passing other arguments without an explicit keyword will result in an error or misinterpretation.
  FutureWarning

Tested with
sktime: '0.4.3'
seaborn: ''0.11.0'

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

PR checklist

For all contributions
  • I've added myself to the list of contributors.
  • Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
  • I've added unit tests and made sure they pass locally.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

Any other comments?

The function as written produces the following warning (which will become an error)
```
/usr/local/lib/python3.7/site-packages/seaborn/_decorators.py:43: FutureWarning: Pass the following variables as keyword args: x, y. From version 0.12, the only valid positional argument will be `data`, and passing other arguments without an explicit keyword will result in an error or misinterpretation.
  FutureWarning
```
Tested with 
sktime: '0.4.3'
seaborn: ''0.11.0'
@davidbp davidbp requested a review from mloning as a code owner November 6, 2020 17:11
Copy link
Contributor

@mloning mloning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbp

@mloning mloning merged commit e4ed292 into sktime:master Nov 8, 2020
@mloning
Copy link
Contributor

mloning commented Nov 8, 2020

Thanks again @davidbp, really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants